Re: [PATCH v7 3/5] ASoC: meson: g12a-toacodec: Add S4 tocodec driver

[Mark Brown]

> The S4 requires additional clock control bits to be turn on while enabled.
> The S4 has 8 TDM lanes, instead of 4 on previous SoC.
> Update the widget accordingly.

> +#define CTRL0_BCLK_ENABLE_SHIFT		30
> +#define CTRL0_MCLK_ENABLE_SHIFT		29

Should these have a _S4 suffix?

>  
> +static const struct snd_soc_dapm_widget s4_toacodec_widgets[] = {
> +	SND_SOC_DAPM_MUX("SRC", SND_SOC_NOPM, 0, 0,
> +			 &sm1_toacodec_mux),

Should this have a custom mux for S4, it looks like the register bits
are different, a shift of 19 for S4.

-- 
Mark Brown <broonie@xxxxxxxxxx>