Re: [PATCH] net/sched: sch_cake: skip redundant cake_mq rate updates

[Shubhang]

Hi Jonas,

> >   -		cake_configure_rates(sch, new_rate, true);
> > +		if (new_rate != READ_ONCE(q->tins[0].tin_rate_bps))
> > +			cake_configure_rates(sch, new_rate, true);
> Thanks! Yes, I think the idea is right. I think we could even omit the
> READ_ONCE.
>
> Best
> Jonas>   		q->last_checked_active = now;
> >   		WRITE_ONCE(q->active_queues, num_active_qs);

Thanks for the review. Yes, the qdisc lock serializes this access,
so READ_ONCE() is not needed. I’ll send a v2 with it removed.

Regards,
Shubhang Kaushik