Re: [PATCH] usb: typec: ucsi: acpi: Assume UCSI 1.0 on HP ZBook 8 G2i 14

[Huang Wei]

Hi Ihor,

I had a look at this - the approach looks right, and it follows the
precedent that's already in the tree: ucsi_acer_read_version()
handles the exact same zero-version firmware behaviour on the Acer
Nitro ANV15-41 with the same read-then-substitute pattern, so this
is the second instance of a recurring problem class rather than a
one-off hack. Overriding read_version() is also the clean hook: it's
called from exactly one place in the core (ucsi_register()), so the
substitution fires once per probe, and passing non-zero versions
through unchanged means a later re-registration picks up the real
firmware value once the firmware has filled it in.

One small thing: the Fixes tag points at c1b0bc2dabfa, but the
failure mode being fixed - registration rejected with -ENODEV when
VERSION reads zero - only exists since bdc62f2bae8f ("usb: typec:
ucsi: Simplified registration and I/O API"), which introduced the
!version check. Might be worth pointing the Fixes tag there instead
for accurate attribution, though given the machine is new enough the
stable backport range is academic either way.

Reviewed-by: Huang Wei <huangwei@xxxxxxxxxx>

Thanks,
Huang Wei