Re: [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable
From: Jarkko Sakkinen
Date: Mon Oct 26 2026 - 23:02:22 EST
On Mon, Oct 26, 2026 at 06:29:52PM -0700, Eric Biggers wrote:
> As I suggested before, I think the hash field (here and in struct key)
> should be changed to u32, since that is all that is used now. Also, the
> SipHash value can just be truncated from 64 bits to 32 instead of
> "folded". Also, the pointers can be used directly in the computation
> once again, now that they're no longer needed for the assoc_array key.
> (And that means the domain_id and type_id can be removed.)
>
> Are those simplifications planned for follow-up commits, maybe?
No this is my bad. I'll fix it for the next version.
Sorry about this.
Br, Jarkko