Re: [PATCH v22 11/14] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions
From: Hangxiang Ma
Date: Tue Oct 27 2026 - 00:26:54 EST
On 10/27/2026 12:29 AM, Loic Poulain wrote:
> On Sun, Oct 25, 2026 at 4:17 AM Hangxiang Ma
> <hangxiang.ma@xxxxxxxxxxxxxxxx> wrote:
>>
>> Describe the CAMSS and CSIPHY blocks on Kaanapali so that camera pipelines
>> can be enabled by board device trees.
>>
[...]
>> + camss: isp@9253000 {
>> + compatible = "qcom,kaanapali-camss";
>> +
>> + reg = <0x0 0x09253000 0x0 0x5e80>,
>> + <0x0 0x09263000 0x0 0x5e80>,
>> + <0x0 0x09273000 0x0 0x5e80>,
>> + <0x0 0x092d3000 0x0 0x3880>,
>> + <0x0 0x092e7000 0x0 0x3880>,
>> + <0x0 0x093fd000 0x0 0x400>,
>> + <0x0 0x093fe000 0x0 0x400>,
>> + <0x0 0x093ff000 0x0 0x400>,
>> + <0x0 0x09151000 0x0 0x20000>,
>> + <0x0 0x09171000 0x0 0x20000>,
>> + <0x0 0x09191000 0x0 0x20000>,
>> + <0x0 0x092dc000 0x0 0x1300>,
>> + <0x0 0x092f0000 0x0 0x1300>;
>> + reg-names = "csid0",
>> + "csid1",
>> + "csid2",
>> + "csid_lite0",
>> + "csid_lite1",
>> + "csitpg0",
>> + "csitpg1",
>> + "csitpg2",
>> + "vfe0",
>> + "vfe1",
>> + "vfe2",
>> + "vfe_lite0",
>> + "vfe_lite1";
>
> I think we should probably start adding the CAMSS "top" register
> region as well, to provide a more complete description of the CAMSS
> hardware block. This register space contains, among other things, the
> CAMSS hardware version information.
>
Ack. I double-checked and found that Agatti, Shikra, and QCM2290 have
already followed this newly introduced register layout. I'll update both
the binding and DTSI accordingly in the next revision.
---
Best Regards,
Hangxiang