Re: [PATCH v4 04/31] ntfs: preserve attribute search context initialization errors

From: liubaolin

Date: Tue Oct 27 2026 - 02:17:25 EST




在 2026/10/27 13:46, Hyunchul Lee 写道:
Hi,

@@ -5476,7 +5480,7 @@ int ntfs_attr_exist(struct ntfs_inode *ni, const __le32 type, __le16 *name,
ntfs_debug("Entering\n");
ctx = ntfs_attr_get_search_ctx(ni, NULL);
- if (!ctx) {
+ if (IS_ERR(ctx)) {
ntfs_error(ni->vol->sb, "%s: Failed to get search context",
__func__);
return 0;

ntfs_attr_exist() still turns ntfs_attr_get_search_ctx() errors into
'attribute absent'.

Hi HyunchulLee,
You're right. In v5, I'll make ntfs_attr_exist() preserve errors and update its callers to distinguish errors from an absent attribute.

Thanks,
Baolin.


--
2.51.0