Re: [PATCH v2 5/6] dt-bindings: iio: adc: ti,ads1298: add ADS1299

[Krzysztof Kozlowski]

On Sat, Oct 24, 2026 at 08:13:34PM -0300, Stephan Costa Barros wrote:
> The ADS1299 is an 8-channel, 24-bit biopotential ADC for EEG with the
> register map of the ADS129x. It differs in its gains, data rates and
> ID layout, and has a fixed 4.5 V internal reference. The ADS1299-4 and
> ADS1299-6 are the same part with four and six channels.
> 
> TI sells the 8-channel part as plain ADS1299, so ti,ads1299 names it,
> and it is the fallback for ti,ads1299-4 and ti,ads1299-6: the channel
> count can be read from the ID register. The ADS1299 is not compatible
> with the ADS1298, so ti,ads1298 is not a fallback for it.
> 
> In the same way, give each ADS129x part a compatible, with ti,ads1298 as
> the fallback: the ID register tells the parts apart, by family and
> channel count. ti,ads1298 alone remains valid, so existing device trees
> are not affected.
> 
> Both families have a digital supply, DVDD, and an active-low power-down
> pin, PWDN, which the binding did not describe. Add them, both optional.
> 
> Add myself as a maintainer of the binding, next to Mike.
> 
> Signed-off-by: Stephan Costa Barros <stephanbrrs8@xxxxxxxxx>
> ---
>  .../bindings/iio/adc/ti,ads1298.yaml          | 41 +++++++++++++++----
>  1 file changed, 34 insertions(+), 7 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof