Re: [PATCH] net: phy: air_en8811h: add dedicated suspend callback for AN8811HB

[WeiTing Lee (李威霆)]

Hi Andrew,

Thanks for the review. I need to check this internally, which will
take some time. I will continue with the other patches in the
meantime.

Thanks,
Weiting

On Thu, Sep 17, 2026 at 09:56 +0800, Andrew Lunn wrote:
> > The AN8811HB hardware requires a re-negotiation sequence before
> > entering power-down to correctly restore the link upon resume.
> > Add an8811hb_suspend() to handle this.
>
> Is there an errata for this? Please mention it in the commit message.
>
> > +static int an8811hb_suspend(struct phy_device *phydev)
> > +{
> > +     int ret;
> > +
> > +     clk_save_context();
> > +
> > +     ret = phy_modify(phydev, MII_BMCR, 0, BMCR_ANRESTART);
>
> Why use phy_modify() if you are going to pass a mask of 0?
>
>         Andrew