Re: [PATCH net v2 2/3] rxrpc: Fix counting of in-flight transmitted packets

[Paolo Abeni]

On 10/22/26 02:00, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 2 · Low: 0 (1)
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] Incomplete in-flight accounting: if a segment that is already
>    soft-ACKed gets retransmitted, its tq->in_flight bit is set again and…
> - [Medium] Behaviour change on soft-ACK reneging (ACK->NAK flip).
Basically sashiko says that the accounting looks still not perfect. Is not
clear to me the new status is good enough.

Side notes: sashiko comments on patch 3/3 are not blockers, but you should
revisit the commit message in case of a repost (and do not include patch 1/3,
postponed to net-next).

/P