Re: [PATCH] ksmbd: use the resolved share path for the share root

[Namjae Jeon]

On Mon, Oct 26, 2026 at 9:56 PM Denis Kulikov <dar1knessx@xxxxxxxxx> wrote:
>
> If the share path is a mount point and crossmnt is not set (crossmnt = no,
> or ksmbd-tools that predate the option), the share root looks empty to
> clients: QUERY_DIRECTORY on it returns only "." and "..". Files created
> in the root go to the mounted filesystem, but a directory query cannot
> find them afterwards, so e.g. "rm" of a file that was just uploaded
> fails with STATUS_NO_SUCH_FILE.
>
> An empty name refers to the share root. For it, ksmbd_vfs_path_lookup()
> looks up share_conf->path again starting from its parent, and the mount
> on the last component is not followed, which gives the directory covered
> by the mount. All other names are looked up relative to
> share_conf->vfs_path, which was resolved through the mount when the
> share was set up.
>
> share_conf->vfs_path already refers to the share root, so return a
> reference to it instead of looking the path up again.
>
> Fixes: 74d7970febf7 ("ksmbd: fix racy issue from using ->d_parent and ->d_name")
> Signed-off-by: Denis Kulikov <dar1knessx@xxxxxxxxx>
Applied it to #ksmbd-for-next.
Thanks!