Re: [PATCH v3 1/2] dt-bindings: power: rockchip: Add RK3572 power domains
From: Krzysztof Kozlowski
Date: Tue Oct 27 2026 - 06:16:48 EST
On Mon, Oct 26, 2026 at 11:21:38AM +0800, Cunhao Lu wrote:
> From: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx>
>
> Define the RK3572 power-domain IDs. The driver uses the system GRF to
> check firmware shift-ready status after powering on a domain.
>
> Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx>
>
> - Added the rockchip,grf property.
> - Made the phandle required only for RK3572.
>
Some mess here. I don't get what's above, but does not fit commit msg.
Also there are no commit msg between the tags.
> Signed-off-by: Cunhao Lu <1579567540@xxxxxx>
> ---
> .../bindings/power/rockchip,power-controller.yaml | 17 ++++++++++++
> .../power/rockchip,rk3572-power-controller.h | 30 ++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index b41db576f95d..f8afb0fabe80 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -43,6 +43,7 @@ properties:
> - rockchip,rk3528-power-controller
> - rockchip,rk3562-power-controller
> - rockchip,rk3568-power-controller
> + - rockchip,rk3572-power-controller
> - rockchip,rk3576-power-controller
> - rockchip,rk3588-power-controller
> - rockchip,rv1126-power-controller
> @@ -57,6 +58,22 @@ properties:
> "#size-cells":
> const: 0
>
> + rockchip,grf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: System GRF with firewall readiness status.
What is firewall? Is it for access control? If so, we have
access-controllers properties.
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + const: rockchip,rk3572-power-controller
> + then:
> + required:
> + - rockchip,grf
> + else:
> + properties:
> + rockchip,grf: false
> +
Best regards,
Krzysztof