Re: [PATCH v5 18/21] phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers

[Michal Wilczynski]

On 9/30/26 12:14, Heiko Stübner wrote:
> Am Dienstag, 29. September 2026, 12:31:15 Mitteleuropäische Sommerzeit schrieb Michal Wilczynski:
>> The RK3328 pre-PLL programming, its table lookup and its recalc_rate and
>> determine_rate implementations are the generic Innosilicon ones, so drop
>> the local copies and use the shared helpers instead.
>>
>> The RK3228 pre-PLL sits at different register addresses, so it keeps its
>> own register level code and only shares the table lookup.
>>
>> The now unused RK3328 pre-PLL register macros go with it, as does the
>> local pre-PLL config lookup wrapper; both call sites already have the
>> TMDS clock to hand and call inno_hdmi_phy_pre_pll_lookup() directly.
>>
>> The RK3328 recalc_rate used to log the pre-PLL output as "vco". The
>> shared helper logs it too, and reports the actual VCO frequency
>> alongside the rate, which is the value with the 1.4-3.2 GHz constraint.
>>
>> The register writes, their order and the values written are unchanged.
>> No functional change intended.
>>
>> Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
>> Reviewed-by: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> 
> Only thing I cannot really make up my mind about, is if this and the
> previous patch should be merged ("move common code from rockchip
> variant to shared helper").
> 
> As I said, can't really decide what would be the better solution ;-) .

I split them deliberately as I don't have Rockchip hardware. It's easier
to verify this commit's correctness and the claims 'no functional change
intended' and 'the register writes, their order and the values written
are unchanged' when split, as the previous commit only adds the library
and this one only deletes the RK3328 copy and calls into it.

> 
> 
> Heiko
> 
> 
> 

Best regards,
-- 
Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>