Re: [PATCH v3 1/3] dt-bindings: clock: rockchip: Add RK3572 CRU

[Krzysztof Kozlowski]

On 27/10/2026 11:43, Heiko Stübner wrote:
> Am Dienstag, 27. Oktober 2026, 11:17:08 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
> 
> With code originating in the vendor kernel, it is nice to know what changed,
> but I guess there is a tradeoff between brevity and more details.

Honestly I disagree :). Vendor kernel commits and their messages are
irrelevant per se. They are only useful as source of knowledge, but what
was exactly written there does not matter. Quality is dubious, coding
practices are terrible. We want to extract the knowledge, the important
details, but not the exact commit. We do not care what changed from
downstream to upstream, because we know that downstream sucks so much
that we don't even want to touch it.

> 
> I guess this could be shorted to something less verbose, like
> 
> +++++++++++++
> Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> [adapted to mainline rockchip clock and reset handling (xin24m input,
>   don't introduce CLK_NR_CLKS, etc ]
> Signed-off-by: Cunhao Lu <1579567540@xxxxxx>
> +++++++++++++

Yes, if this brings anything useful. For example removal of CLK_NR_CLKS
is completely pointless to mention. How does it explain the hardware or
design choices? How does it explain why this driver was written that or
other way?

Just take the authorship of downstream commits and send them as your
own. Both GPL and DCO allow this and if downstream did not bother to
upstream that stuff, they do not deserve credits.


Best regards,
Krzysztof