Re: [PATCH] power: sequencing: pcie-m2: Drive the Key E SDIO_RESET# signal

[Manivannan Sadhasivam]

On 2026-10-26 13:56 +0000, William Bright wrote:
> On Mon, Oct 26, 2026 at 06:16:38PM +0530, Manivannan Sadhasivam wrote:
> > 
> > Do we have SDIO pwrseq consumer driver in mainline?
> > 
> > 
> 
> No. MMC still uses its own mmc-pwrseq framework.
> 
> > You should not add GPIO control to the pwrseq_pcie_m2_vregs_{enable/disable}()
> > callbacks. You should create a new 'sdio-enable' and populate
> > pwrseq_unit_data->enable/disable callbacks for the SDIO_RESET# control.
> 
> An sdio-enable unit wouldn't ever be called until MMC gains a consumer.

Yes.

> Should I add the unit anyway, or drop this patch until an SDIO user
> exists? Maybe I should switch to working on this first? But it looks to
> be quite a big task.
> 

If there is no user, then the unit will be a dead code and we don't add dead
code in the kernel.

- Mani