Re: [PATCH v2 2/9] irqchip: irq-qcom-mpm: Register MPM with cpu_pm for RPM notification

From: Sneh Mankad

Date: Tue Oct 27 2026 - 08:55:04 EST




On 19-10-2026 16:40, Konrad Dybcio wrote:
> On 10/15/26 11:55 AM, Sneh Mankad wrote:
>> MPM irqchip needs to notify RPM (Resource Power Manager) processor to read
>> the latest wake up capable interrupts when the CPU cluster is entering the
>> deepest idle state. This is done by sending IPC interrupt to RPM and is
>> implemented as .power_off() callback by registering MPM as parent power
>> domain to CPU cluster.
>
> GPT suggests to register the notifier later, so that if
> mbox_request_channel() probedefers we get a clean unwinding.
>
> It also suggests to skip pm_genpd_remove() in the non-legacy
> case, but the API tolerates nullptrs (although it does return
> -EINVAL, but we ignore the value)

I will move the genPD/cpu_pm registration after mbox_request_channel() to fix this.
As for pm_genpd_remove(), as you mentioned it is harmless since it will return -EINVAL
without disturbing anything else.

Thanks,
Sneh