Re: [PATCH v7 03/12] gpio: mxc: use 'unsigned int' instead of bare 'unsigned'

[Frank Li]

On Tue, Oct 27, 2026 at 08:09:30PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> The kernel coding style prefers 'unsigned int' over bare 'unsigned'.
> Fix all instances in struct mxc_gpio_hwdata and mxc_gpio_to_irq().
>
> No functional change.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/gpio/gpio-mxc.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 848d7725ccfe..43868a214c17 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -36,18 +36,18 @@
>
>  /* device type dependent stuff */
>  struct mxc_gpio_hwdata {
> -	unsigned dr_reg;
> -	unsigned gdir_reg;
> -	unsigned psr_reg;
> -	unsigned icr1_reg;
> -	unsigned icr2_reg;
> -	unsigned imr_reg;
> -	unsigned isr_reg;
> +	unsigned int dr_reg;
> +	unsigned int gdir_reg;
> +	unsigned int psr_reg;
> +	unsigned int icr1_reg;
> +	unsigned int icr2_reg;
> +	unsigned int imr_reg;
> +	unsigned int isr_reg;
>  	int edge_sel_reg;
> -	unsigned low_level;
> -	unsigned high_level;
> -	unsigned rise_edge;
> -	unsigned fall_edge;
> +	unsigned int low_level;
> +	unsigned int high_level;
> +	unsigned int rise_edge;
> +	unsigned int fall_edge;
>  };
>
>  struct mxc_gpio_reg_saved {
> @@ -367,7 +367,7 @@ static int mxc_gpio_init_gc(struct mxc_gpio_port *port, int irq_base)
>  	return rv;
>  }
>
> -static int mxc_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
> +static int mxc_gpio_to_irq(struct gpio_chip *gc, unsigned int offset)
>  {
>  	struct mxc_gpio_port *port = gpiochip_get_data(gc);
>
>
> --
> 2.51.0
>
>