Re: [PATCH v2] drm/msm/gem: Add some cleanup.h

[Konrad Dybcio]

On 10/27/26 3:14 PM, Rob Clark wrote:
> Convert (most of) the msm_gem_lock() and friends over to scope based
> cleanup.
> 
> Other than fixing a lock leak in msm_ioctl_gem_info_set_metadata() there
> should be no functional change.

[...]


> @@ -608,26 +600,20 @@ static int msm_ioctl_gem_info_get_metadata(struct drm_gem_object *obj,
>  		return 0;
>  	}
>  
> -	ret = msm_gem_lock_interruptible(obj);
> -	if (ret)
> -		return ret;

LLM is a bit grumpy since this no longer returns all of the return
codes that it can but I think it doesn't matter

There's a couple of single-line-scopes we could shave off but any
which way

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad