Re: [PATCH v1 1/2] mfd: tps65910: Use devm_register_power_off_handler()

[Lee Jones]

--- checkpatch.pl: clean (0 issues) ---

On Thu, 15 Oct 2026, Svyatoslav Ryhel wrote:

> From: Dmitry Osipenko <digetx@xxxxxxxxx>
>
> Use devm_register_power_off_handler() that replaces global pm_power_off
> variable and allows to register multiple power-off handlers.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> ---
>  drivers/mfd/tps65910.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 6243b66b1b6f2..18b76359046b8 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -16,6 +16,7 @@
>  #include <linux/irq.h>
>  #include <linux/irqdomain.h>
>  #include <linux/mfd/core.h>
> +#include <linux/reboot.h>
>  #include <linux/regmap.h>
>  #include <linux/mfd/tps65910.h>
>  #include <linux/of.h>
> @@ -425,9 +426,9 @@ struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
>  }
>  #endif
>
> -static struct i2c_client *tps65910_i2c_client;
> -static void tps65910_power_off(void)
> +static int tps65910_power_off(struct sys_off_data *data)
>  {
> +	struct i2c_client *tps65910_i2c_client = data->cb_data;
>  	struct tps65910 *tps65910;
>
>  	tps65910 = dev_get_drvdata(&tps65910_i2c_client->dev);

Why not pass 'tps65910' directly as 'cb_data' instead of 'i2c' and save this
lookup?

> @@ -435,6 +436,8 @@ static void tps65910_power_off(void)
>  	regmap_update_bits(tps65910->regmap, TPS65910_DEVCTRL,
>  			   DEVCTRL_DEV_OFF_MASK | DEVCTRL_DEV_ON_MASK,
>  			   DEVCTRL_DEV_OFF_MASK);
> +
> +	return NOTIFY_DONE;
>  }
>
>  static int tps65910_i2c_probe(struct i2c_client *i2c)
> @@ -501,7 +504,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c)
>  	tps65910_ck32k_init(tps65910, pmic_plat_data);
>  	tps65910_sleepinit(tps65910, pmic_plat_data);
>
> -	if (pmic_plat_data->pm_off && !pm_power_off) {
> +	if (pmic_plat_data->pm_off) {
>  		/*
>  		 * The PWR_OFF bit needs to be set separately, before
>  		 * transitioning to the OFF state. It enables the "sequential"
> @@ -515,8 +518,13 @@ static int tps65910_i2c_probe(struct i2c_client *i2c)
>  			return ret;
>  		}
>
> -		tps65910_i2c_client = i2c;
> -		pm_power_off = tps65910_power_off;
> +		ret = devm_register_power_off_handler(&i2c->dev,
> +						      tps65910_power_off, i2c);
> +		if (ret) {
> +			dev_err(&i2c->dev,
> +				"failed to register power-off handler: %d\n", ret);
> +			return ret;
> +		}

dev_err_probe()?

>  	}
>
>  	ret = devm_mfd_add_devices(tps65910->dev, -1,
> -- 
> 2.53.0
>

-- 
Lee Jones