Re: [PATCH] mfd: twl6040: fix IRQ action memory leaks during teardown

[Krzysztof Kozlowski]

On 27/10/2026 04:26, Guangshuo Li wrote:
> twl6040_remove() currently removes the regmap IRQ chip before
> removing the MFD child devices. This destroys the IRQ mappings
> before the child drivers can release their interrupt handlers.
> 
> The parent driver also registers READY and thermal interrupt
> handlers using devm_request_threaded_irq(). These handlers are
> normally released by device-managed cleanup after remove returns,
> when the corresponding IRQ descriptors have already been removed.
> 
> Consequently, free_irq() cannot find the IRQ descriptors and the
> allocated struct irqaction objects are not freed. The associated
> IRQ threads also cannot be stopped through the normal cleanup path.
> 
> The probe error paths have a similar issue, as they destroy the IRQ
> chip before the device-managed IRQ handlers are released.
> 
> Remove the MFD child devices first, then explicitly free the
> parent's READY and thermal IRQ handlers using devm_free_irq()
> before removing the regmap IRQ chip.
> 
> Also update the probe error paths to release successfully requested
> IRQs before destroying their mappings.
> 

More of postings by bot ignoring any feedback.

Best regards,
Krzysztof