Re: [PATCH] nvmet-fc: extend critical section in nvmet_fc_remove_port()

From: paritoshpotukuchi

Date: Tue Oct 27 2026 - 12:09:56 EST


> I don't think this safe.
> nvmet_fc_tgtport_put() can end up calling fcloop_targetport_delete()
> which calls flush_work(), therefore you call a blocking function while
> in atomic context

Thanks for pointing that out.

The current implementation of nvmet_fc_portentry_unbind calls
nvmet_fc_tgtport_put() while holding a spinlock.

>From what we understand, this seems to be a design flaw,
since flush_work() is still being called while holding a spinlock.


Paritosh