Re: [PATCH 1/7] media: i2c: ov7251: Fix link frequency index
From: Dan Scally
Date: Tue Oct 27 2026 - 12:38:30 EST
Hello
On 27/10/2026 10:26, D. Manresa wrote:
<snip>
So either ipu-bridge's advertised link frequency is wrong for this SKU,
or mainline's 319.2 MHz PLL entry needs more than the index fix to be
usable. I have the machine for a few more days and can run whatever would
help decide which.
It would be worth validating the settings for the 319.2MHz link frequency to make sure that the PLL is being configured correctly. The link frequency itself advertised by the ipu-bridge strictly just needs to be one that the sensor driver is capable of configuring, but ideally we would make sure that the sensor can configure one that these platforms tend to use, as the platform designers will generally choose it carefully to be appropriate for their device. When I made these changes I checked and the driver for my Surface Go 2 was setting 319.2 MHz, so I would be more suspicious of the driver's PLL settings than that value.
Dan
The rest of the series tests well here; I have replied to the cover letter
with that.
D. Manresa
(Written with AI assistance, directed and reviewed by me.)