Re: [PATCH v3 0/5] media: atomisp: remove the circbuf library

[Andy Shevchenko]

On Tue, Oct 27, 2026 at 12:03:35PM +0000, Rareș-Mihai Vladu wrote:
> Thanks to Andy for suggesting, in review of my earlier typedef
> patch [1], that I look at converting the custom circbuf code to
> circ_buf or kfifo, and for reviewing the previous versions.
> 
> While looking into it, I found that the circbuf API is only used by
> the local queue path, and ia_css_queue_local_init() has no callers,
> so as far as I can tell that path is unused. The remote queues only
> need the descriptor and element layout shared with the SP firmware
> and a few small helpers.
> 
> So this series first moves the remote queue handling into helpers,
> then removes the unused local path together with the queue type that
> no longer seems to serve a purpose, moves the few remaining pieces
> into ia_css_queue_comm.h and drops base/circbuf/. I may well be
> missing something, so please let me know if a different approach
> would be better and I will rework it.
> 
> checkpatch warns about new typedefs in patch 4 and about MAINTAINERS
> in patch 5. The typedefs are only moved from ia_css_circbuf_comm.h,
> which patch 5 deletes, and MAINTAINERS has no entries for the removed
> files.

Almost there! The few minor amendments to the patch 2 and I think we
good to go, I believe next version will be final for this part of job.

> Compile-tested only.
> 
> This supersedes the typedef patch [1].

And thanks for doing this! This is the real cleanup series from people who
want to learn while doing something against staging. I will point others
in the future to this success story.

-- 
With Best Regards,
Andy Shevchenko