Re: [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property
From: Vishnu Saini
Date: Tue Oct 27 2026 - 14:19:20 EST
On Tue, Oct 27, 2026 at 03:34:19PM +0100, Krzysztof Kozlowski wrote:
> On 27/10/2026 11:57, Vishnu Saini wrote:
> > On Tue, Oct 27, 2026 at 09:12:27AM +0100, Krzysztof Kozlowski wrote:
> >> On Sun, Oct 25, 2026 at 12:18:17PM +0530, Vishnu Saini wrote:
> >>> The DLC0697 panel is lit by a separate backlight device, which is
> >>> referenced from the panel node through the common 'backlight'
> >>> property.
> >>>
> >>> Declare 'backlight: true' so the property is explicitly allowed by the
> >>> schema.
> >>
> >> Why do you need to explicitly allow it? Since when?
> >>
> >> I see no benefit of this patch and commit msg does not explain me what
> >> that benefit would be.
> > It is required for below DLC panel, when enabling backlight using gpio-backlight driver,
>
> How is it required? You did not really answer, so again:
>
> Why do you need to explicitly allow it?
>
> Answer starts "because ... " and you provide technical arguments, not
> wishes.
Because the DLC panel node references an external gpio-backlight device through the
backlight property, but the current DLC binding does not allow this property.
As a result, adding the backlight phandle to the panel node causes a dtbs_check validation error.
Adding backlight: true to the binding allows the common panel backlight property used by this DT.
I will improve the commit message.
>
> Best regards,
> Krzysztof