Re: [PATCH v4 1/4] dt-bindings: clock: rockchip: Add RK3572 CRU
From: Krzysztof Kozlowski
Date: Tue Oct 27 2026 - 14:32:09 EST
On Tue, Oct 27, 2026 at 06:04:28PM +0800, Cunhao Lu wrote:
> From: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
>
> The RK3572 CRU uses the PMU0 GRF for the AUPLL reference mux.
> Describe the controller and define its clock and reset IDs.
>
> Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
>
> - Documented the xin24m input.
> - Made the PMU0 GRF phandle required.
> - Updated the example.
> - Closed the reset ID gap while preserving each named reset's register
> mapping.
> - Removed CLK_NR_CLKS from the clock binding.
>
> Signed-off-by: Cunhao Lu <1579567540@xxxxxx>
Same comments as in other places. I probably responded to older version.
Best regards,
Krzysztof