Re: [PATCH] docs: submitting-patches: Require base tree information

From: Mark Brown

Date: Tue Oct 27 2026 - 14:57:27 EST


On Tue, Oct 27, 2026 at 02:33:10PM +0200, Laurent Pinchart wrote:
> On Mon, Oct 26, 2026 at 08:51:35PM +0000, Mark Brown wrote:

> > This isn't insurmountable, you can cherry pick the
> > changes over to a clean branch or something, but there's new failure
> > modes introduced by being explicit about the commit (the number of times
> > I've had to unwind a series apply in b4 because it paid attention to an
> > unsuitable sender specified base...).

> I've seen that too. So far it has bothered me less than not having base
> information. With an unsuitable base I can apply the patches ignoring
> the base, while with missing base I have to ask the submitter. The
> latter interrupts review. Your mileage may vary though, depending on how
> often you hit either case.

Some of it is a consequence of how I handle these situations - if I
can't work out how to apply the patch against something I'm likely to
apply the patch to I'll just ask the submitter to rebase before I get
terribly far into things, if I get as far as pulling the patch in before
I notice b4 used a weird base (usually picked up from the submitter) and
I didn't override it then that's pretty cumbersome to unwind.

Attachment: signature.asc
Description: PGP signature