Re: [PATCH] input: keyboard: Convert to DEFINE_SIMPLE_DEV_PM_OPS()

[Frank Li]

On Fri, Aug 21, 2026 at 09:39:51AM +0700, Triet Hoang wrote:
> Convert deprecated SIMPLE_DEV_PM_OPS
> to DEFINE_SIMPLE_DEV_PM_OPS and pm_sleep_ptr().
>
> This lets us drop the __maybe_unused annotations
> from the resume callbacks and reduces kernel size
> when CONFIG_PM or CONFIG_PM_SLEEP is disabled.
>
> Signed-off-by: Triet Hoang <triet.hoang.dev@xxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/input/keyboard/imx-sm-bbm-key.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/imx-sm-bbm-key.c b/drivers/input/keyboard/imx-sm-bbm-key.c
> index 96486bd23d60..7fbbd44878be 100644
> --- a/drivers/input/keyboard/imx-sm-bbm-key.c
> +++ b/drivers/input/keyboard/imx-sm-bbm-key.c
> @@ -187,7 +187,7 @@ static int scmi_imx_bbm_key_probe(struct scmi_device *sdev)
>  	return ret;
>  }
>
> -static int __maybe_unused scmi_imx_bbm_key_suspend(struct device *dev)
> +static int scmi_imx_bbm_key_suspend(struct device *dev)
>  {
>  	struct scmi_imx_bbm *bbnsm = dev_get_drvdata(dev);
>
> @@ -196,12 +196,12 @@ static int __maybe_unused scmi_imx_bbm_key_suspend(struct device *dev)
>  	return 0;
>  }
>
> -static int __maybe_unused scmi_imx_bbm_key_resume(struct device *dev)
> +static int scmi_imx_bbm_key_resume(struct device *dev)
>  {
>  	return 0;
>  }
>
> -static SIMPLE_DEV_PM_OPS(scmi_imx_bbm_pm_key_ops, scmi_imx_bbm_key_suspend,
> +static DEFINE_SIMPLE_DEV_PM_OPS(scmi_imx_bbm_pm_key_ops, scmi_imx_bbm_key_suspend,
>  			 scmi_imx_bbm_key_resume);
>
>  static const struct scmi_device_id scmi_id_table[] = {
> @@ -212,7 +212,7 @@ MODULE_DEVICE_TABLE(scmi, scmi_id_table);
>
>  static struct scmi_driver scmi_imx_bbm_key_driver = {
>  	.driver = {
> -		.pm = &scmi_imx_bbm_pm_key_ops,
> +		.pm = pm_sleep_ptr(&scmi_imx_bbm_pm_key_ops),
>  	},
>  	.name = "scmi-imx-bbm-key",
>  	.probe = scmi_imx_bbm_key_probe,
> --
> 2.53.0
>