Re: [PATCH v2] phy: qcom-mipi-csi2: Add support for single power-domain SoCs

[Bryan O'Donoghue]

On 28/10/2026 05:20, Anusha Arun Nandi wrote:
> -	if (ret < 0 || csi2phy->pd_list == NULL) {
> -		if (ret == 0)
> -			ret = -ENODEV;
> +	if (ret < 0)
>   		return dev_err_probe(dev, ret, "Failed to attach power-domain list\n");
> -	}

Shouldn't this be

if (ret < 0 || ( csi2phy->soc_cfg->num_genpds > 1 && csi2phy->pd_list == 
NULL) {

i.e. you are dropping the NULL check for the case of multiple power-domains.

---
bod