Re: [PATCH 2/3] arm64: dts: qcom: lemans: make the emac compatible specific to the embedded variant

[Bartosz Golaszewski]

On Wed, 28 Oct 2026 11:13:11 +0100, Shawn Guo
<shengchao.guo@xxxxxxxxxxxxxxxx> said:
> On Wed, Oct 28, 2026 at 01:25:34AM -0700, Bartosz Golaszewski wrote:
>> On Mon, 26 Oct 2026 09:36:06 +0100, Shawn Guo
>> <shengchao.guo@xxxxxxxxxxxxxxxx> said:
>> > On Fri, Oct 23, 2026 at 11:02:23AM +0200, Bartosz Golaszewski wrote:
>> >> The embedded and gearvm variants of the ethernet MAC use different
>> >> compatibles so move the one for sa8775p into lemans-embedded.dtsi and
>> >> make place for the gearvm variant to be placed in lemans-gearvm.dtsi.
>> >>
>> >> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
>> >
>> > Do we run into any problem if lemans-gearvm.dtsi simply overwrites
>> > the compatible without this patch?
>> >
>>
>> Technically no, but then lemans.dtsi is incorrect as the MAC compatible depends
>> on the firmware variant. I'd move it if you're already touching the files
>> anyway.
>
> This will be inconsistent to what we generally do today for both
> Lemans and Nord, i.e. we are defaulting compatible to Embedded variant
> in <soc>.dtsi and overwriting it as needed in <soc>-gearvm.dtsi.
>

Hmm. I don't think I have the authority to make this decision so feel free to
leave it out for now.

Bart