Re: [PATCH net] ipv6: Add NETCONFA_FORCE_FORWARDING to netconf messages
From: Gabriel Goller
Date: Wed Oct 28 2026 - 06:59:27 EST
On 25.10.2026 15:11, Ido Schimmel wrote:
> On Fri, Oct 23, 2026 at 12:59:18PM +0200, Gabriel Goller wrote:
> > Since force_forwarding was added, changing the sysctl sends an
> > RTM_NEWNETCONF notification of type NETCONFA_FORCE_FORWARDING, but
> > inet6_netconf_fill_devconf() never emits the attribute. Listeners only
> > receive NETCONFA_IFINDEX without the new value, and RTM_GETNETCONF
> > replies and dumps omit it as well.
> >
> > Fixes: f24987ef6959 ("ipv6: add `force_forwarding` sysctl to enable per-interface forwarding")
> > Signed-off-by: Gabriel Goller <g.goller@xxxxxxxxxxx>
>
> This seems to fall under the "Not a regression, not critical" category
> [1], so can wait for net-next.
Agree, will post when net-next opens again.
> Also, NETCONFA_FORCE_FORWARDING is not emitted when it's disabled as
> part of:
>
> sysctl -wq net.ipv6.conf.all.forwarding=0
>
> Is this intentional?
Nope it isn't. Will fix in the next version.
Thanks for the review!
Gabriel
> [1] https://lore.kernel.org/netdev/CAHk-=wiSnTE9vBZ=5_v+3EEkdazCCbBM5YABRzRHUAeRdyd4Xw@xxxxxxxxxxxxxx/