Re: [PATCH 1/3] dt-bindings: input: Add compatibility for Awinic AW86224
From: Krzysztof Kozlowski
Date: Wed Oct 28 2026 - 07:07:21 EST
On Tue, Oct 27, 2026 at 11:01:23PM +0100, Gergo Koteles wrote:
> Add the AW86224 haptic driver to the binding documentation for the
> AW86927 and AW86938, as this binding needs the same properties.
>
> They are not compatible though, because the chip identification works
> differently compared to the 86927/86938
>
> Signed-off-by: Gergo Koteles <soyer@xxxxxx>
> ---
> Documentation/devicetree/bindings/input/awinic,aw86927.yaml | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/awinic,aw86927.yaml b/Documentation/devicetree/bindings/input/awinic,aw86927.yaml
> index bd74b81488f6..655633527c01 100644
> --- a/Documentation/devicetree/bindings/input/awinic,aw86927.yaml
> +++ b/Documentation/devicetree/bindings/input/awinic,aw86927.yaml
> @@ -12,11 +12,9 @@ maintainers:
> properties:
> compatible:
> oneOf:
> + - const: awinic,aw86224
> - const: awinic,aw86927
> - - items:
> - - enum:
> - - awinic,aw86938
> - - const: awinic,aw86927
> + - const: awinic,aw86938
I do not understand why you are changing this and commit msg is not
explaining that. You only say that new device is not compatible, but how
is that relevant for existing binding? Anyway, separate commits with
separate reasoning.
Best regards,
Krzysztof