Re: [PATCH v3 2/2] leds: is31f132xx: Add support for is31fl3206

[Lee Jones]

On Tue, 20 Oct 2026, Flávio Amieiro wrote:

> Lee Jones <lee@xxxxxxxxxx> writes:
> 
> > --- checkpatch.pl (1 issue) ---
> > Line 172: WARNING: DT compatible string "issi,is31fl3206" appears un-documented -- check ./Documentation/devicetree/bindings/
> >
> > This true, or is it documented in this set?
> >
> 
> It is documented in the first patch in the series[1].
> 
> 
> >
> > New for() loops should initiate the variable.
> >
> >   for (int i = 0; ...
> >
> 
> I will make sure to initialize the variable in the loop for any new code
> I add in v4. Some of this code, though, was old code that simply moved
> around (and by changing the approach in v4 it might not move anymore).
> 
> Should I add a patch to the series to fix this in portions of the code I
> move to another place?
> 
> If it is helpful, I can also change this in the entire file, just let me
> know if this is welcome as a patch in this series or if it better to
> send it in a different one.
> 
> >
> > Spaces around '+' please.
> >
> 
> This is the same as the for loops: I'll make sure to take this into
> consideration for code added in v4.
> 
> >
> > I detest pointers to functions at the device driver level.
> >
> > Please find another way to do this.
> >
> 
> I'll find another approach for this but, since this is my first patch,
> maybe it's better to align on it before sending in a new version
> unnecessarily to the list.

Sorry, I don't have the time to learn about your device.

Have a think about other ways you can support what you're trying to do,
then attempt to find a solid precedent for it.  You can submit
subsequent attempts "unnecessarily", no one is going to get mad.

-- 
Lee Jones