Re: [PATCH v4 5/9] xfs: limit the count of a pNFS write allocation to one extent
From: Christoph Hellwig
Date: Wed Oct 28 2026 - 12:13:29 EST
On Thu, Oct 22, 2026 at 03:02:30PM +0200, Pankaj Raghav (Samsung) wrote:
> > + /*
> > + * xfs_bmapi_write() maps at most XFS_MAX_BMBT_EXTLEN blocks
> > + * in one mapping, so don't reserve blocks for more. The
> > + * range comes from a client, and its block count may not
> > + * even fit the 32-bit reservation. The rest of the range
> > + * is mapped by a later call.
> > + */
> > + end_fsb = min(end_fsb, offset_fsb + XFS_MAX_BMBT_EXTLEN);
>
> Isn't it better we add this in xfs_direct_write_iomap_begin() instead of
> adding it in pnfs?
Yes, that's what I tried to suggest in the last round.
>