Re: [PATCH v3 01/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire link count for machine driver

[Mukunda,Vijendar]

On 26/10/26 02:29, Pierre-Louis Bossart wrote:
>> diff --git a/sound/soc/amd/acp/soc_amd_sdw_common.h b/sound/soc/amd/acp/soc_amd_sdw_common.h
>> index 034c9ab6e4ea6..5b9410eff56eb 100644
>> --- a/sound/soc/amd/acp/soc_amd_sdw_common.h
>> +++ b/sound/soc/amd/acp/soc_amd_sdw_common.h
>> @@ -17,12 +17,15 @@
>>  
>>  #define ACP63_SDW_MAX_CPU_DAIS		8
> do you still need this define? I was wondering why there's no ACP7X
> equivalent but I can't see anyone using this ACP63 definition?
You're right. |ACP63_SDW_MAX_CPU_DAIS| is currently unused. I'll remove the
definition and send a supplemental patch.
>
>>  #define ACP63_SDW_MAX_LINKS		2
>> +#define ACP7X_SDW_MAX_LINKS		4
>>  
>>  #define AMD_SDW_MAX_GROUPS		9
>>  #define ACP63_PCI_REV			0x63
>>  #define ACP70_PCI_REV			0x70
>>  #define ACP71_PCI_REV			0x71
>>  #define ACP72_PCI_REV			0x72
>> +#define ACP7B_PCI_REV			0x7b
>> +#define ACP7F_PCI_REV			0x7f
>>  
>>  #define SOC_JACK_JDSRC(quirk)		((quirk) & GENMASK(3, 0))
>>  #define ASOC_SDW_FOUR_SPK		BIT(4)