Re:Re: [PATCH 00/12] irqchip: validate remaining MADT records before use

[jiale yao]

At 2026-10-28 16:23:18, "Marc Zyngier" <maz@xxxxxxxxxx> wrote:
>On Wed, 28 Oct 2026 05:00:27 +0000,
>Jiale Yao <yaojiale02@xxxxxxx> wrote:
>> 
>> Several ACPI interrupt-controller callbacks cast generic MADT subtable
>> headers to controller-specific records and access typed fields without
>> first checking that the firmware supplied the complete structure. A
>> truncated entry can therefore cause an out-of-bounds read during early
>> interrupt-controller and CPU discovery.
>> 
>> Add the missing minimum-size checks at the callback boundaries. Records
>> which are passed from a probe validator to an initialization callback are
>> validated once in the validator, before either callback accesses them.
>> 
>> The issues were found by code inspection and have not been tested on real
>> hardware.
>
>How does this compare to the series posted at [1]?
>
>No version number, no change log, and not even an attempt at a QEMU
>test run. If you want people to review this stuff, you need to up your
>game a tiny bit.
>
>	M.
>
>[1] https://lore.kernel.org/20261021144524.364143-1-yaojiale02@xxxxxxx

Thanks for your review, I have added test information, with a new series.

https://lore.kernel.org/lkml/20261029035253.2333852-1-yaojiale02@xxxxxxx/


>
>-- 
>Without deviation from the norm, progress is not possible.