Re: [PATCH v5 01/16] printk: Rename struct console_cmdline to preferred_console

[Chris Down]

Petr Mladek writes:
>The structure 'console_cmdline' was originally intended to store details
>about consoles defined on the kernel command line. However, its usage
>has since expanded; it now stores information for consoles preferred
>via SPCR, device tree, or by particular platforms, e.g. XEN.

A couple of optional nits if you respin:

>@@ -2633,6 +2632,10 @@ static int __init console_setup(char *str)
> 	char *s;
> 	int idx;
> 
>+	static_assert(sizeof(preferred_consoles[0].devname) >=
>+		      sizeof(preferred_consoles[0].name) + 4);
>+
>+

Double blank line here which checkpatch --strict is not happy about.

> #include "printk_ringbuffer.h"
>-#include "console_cmdline.h"
>+#include "console_register.h"
> #include "braille.h"
> #include "internal.h"
> 
>@@ -362,9 +362,9 @@ static int console_locked;
>  *	Array of consoles built from command line options (console=)

This comment still says "Array of consoles built from command line options 
(console=)", which is exactly what the rename is meant to stop implying (as in, 
the array also holds SPCR, DT, etc). Could be updated in this patch if you 
respin.