Re: [PATCH net v6 0/5] more virtio-net csum hardening
From: Michael S. Tsirkin
Date: Thu Oct 29 2026 - 03:25:13 EST
On Wed, Oct 28, 2026 at 03:43:15PM -0700, Jakub Kicinski wrote:
> On Sun, 25 Oct 2026 09:50:24 -0400 Michael S. Tsirkin wrote:
> > > Apologies for reposting so frequently, I know netdev bot will be unhappy
> > > with that. But Paulos's report made a lot of publicity, there is a lot
> > > of people looking into this, so I feel there's value in defending
> > > against all this class of issues sooner rather than later.
> > >
> > > The issues were mostly found by code inspection, but all reproduced by
> > > me in a VM.
> >
> > Ok, I looked at netdev bot review, and there's another issue.
> >
> > If a tunnel inner packet happens to have a valid header at
> > inner_nh_offset, it will pass all checks, but the transport header can
> > in fact overlap e.g. the real TCP header and checksum will overwrite
> > that.
>
> Sorry for boring process stuff but FWIW the last patch also does not
> apply?
> --
> pw-bot: cr
I guess I need to rebase. Still don't have an idea what to do though.
--
MST