Re: [PATCH v2 1/4] regulator: dt-bindings: Add TI LM51772 support

[Paul Louvel]

Hi Krzysztof,

On Thu Oct 29, 2026 at 9:41 AM CET, Krzysztof Kozlowski wrote:
> On Tue, Oct 27, 2026 at 10:39:23AM +0100, Paul Louvel wrote:
>> +          regulator-temp-warn-kelvin:
>> +            enum: [0, 1, 368, 383, 398, 413]
>> +
>> +          regulator-ramp-delay:
>> +            enum: [40000, 20000, 1000, 500]
>> +
>> +          regulator-min-microvolt:
>> +            minimum: 1000000
>> +            maximum: 48000000
>> +
>> +          regulator-max-microvolt:
>> +            minimum: 1000000
>> +            maximum: 48000000
>> +
>> +          regulator-min-microamp:
>> +            minimum: 500000
>> +            maximum: 7000000
>> +
>> +          regulator-max-microamp:
>> +            minimum: 500000
>> +            maximum: 7000000
>> +
>> +        unevaluatedProperties: false
>
> Place this line after description, that's the convention for child nodes
> for readability.
>
>> +
>> +      vcc1:
>> +        type: object
>> +        $ref: regulator.yaml#
>> +        description: |
>> +          LDO regulator for auxiliary use.
>> +          It can used to power, for example, a PD controller that will drive this PMIC.
>> +
>> +        properties:
>> +          regulator-min-microvolt:
>> +            minimum: 5000000
>> +            maximum: 5000000
>> +
>> +          regulator-max-microvolt:
>> +            minimum: 5000000
>> +            maximum: 5000000
>> +
>> +        unevaluatedProperties: false
>
> Place this line after description, that's the convention for child nodes
> for readability.
>
>> +
>> +    additionalProperties: false
>
> Place this line after description (for relevant block), that's the
> convention for child nodes for readability.
>
>> +
>> +  ti,sync-pin:
>> +    description: |
>> +      Selects the function of the SYNC pin, used when several converters
>> +      operate in parallel.
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    enum: [input-rising, input-falling, output-rising, output-falling]
>> +    default: input-rising
>> +
>> +  ti,ivp-thres-microvolt:
>
> Use either existing over-voltage-threshold-microvolt from battery schema
> or ti,ovp-microvolt from the other TI binding.

IVP is not the same as OVP.

>
>> +    description: |
>> +      Input Overvoltage Protection and Regulation Threshold.
>> +      It shall avoid any damage to the device in case the current flows from the
>> +      output to the input and the input source cannot sink current.
>> +      This threshold is used for IVP (Input Voltage Protection) and IVR (Input
>> +      Voltage Regulation).
>> +    oneOf:
>> +      - multipleOf: 125000
>> +        minimum: 4750000
>> +        maximum: 23250000
>> +      - multipleOf: 250000
>> +        minimum: 23500000
>> +        maximum: 50000000
>> +    default: 50000000
>> +
>> +  ti,ivp:
>> +    description: Enable the IVP feature of the regulator.
>> +    type: boolean
>> +
>> +  ti,ivr:
>> +    description: Enable the IVR feature of the regulator.
>> +    type: boolean
>
> Why wouldn't you want to enable these two always?
>

By default, these are off when the device is powered on and these features exist
only for reverse-current situation.

Also if IVP and IVR is on, only the regulation feature is enabled, not the
protection feature. This is a requirement from the datasheet. It is not ideal
and I should not reflect that requirement in the DT.
It should be ti,ivp or ti,ivr but not both because it is confusing.

Or:

ti,input-voltage-mode:
  enum: [protection, regulation]
  ...

>> +
>> +  ti,nint:
>> +    description: |
>> +      Configures the nFLT/nINT pin to act as an interrupt pin.
>> +
>> +      nFLT mode: The pin remains low until the cause of the status change ceases.
>> +      In this mode use an level irq trigger.
>> +
>> +      nINT mode: The pin is asserted low to signal a status change.
>> +      In this mode use an edge irq trigger.
>> +    type: boolean
>> +
>> +  ti,cable-drop-compensation:
>> +    description: |
>> +      The cable drop compensation feature helps to keep the output voltage at the
>> +      nominal value over a wide range of load current without the need for
>> +      additional remote sensing. The cable drop compensation measures the
>> +      current and offsets the output voltage proportionally to the measured
>> +      current.
>> +    type: boolean
>> +
>> +dependencies:
>> +  ti,ivr: ["ti,ivp"]
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>
> Best regards,
> Krzysztof

Thanks.
Best regards,
-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com