Re: [PATCH 3/3] arm64: dts: qcom: glymur: Add EC thermal zones

[Anvesh Jain P]

On 10/20/2026 1:33 PM, Konrad Dybcio wrote:
>> Add support for back cover, keyboard, and SoC thermal zones through
>> temperature sensors hosted on the EC for Glymur and Mahua CRDs.
>>
>> Signed-off-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 45 +++++++++++++++++++++++++++++++-
>>  1 file changed, 44 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
>> index e27c697e3170..571c98124a40 100644
>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
>> @@ -594,10 +594,12 @@ &i2c9 {
>>  
>>  	status = "okay";
>>  
>> -	embedded-controller@76 {
>> +	ec: embedded-controller@76 {
> "ec" is a super short label, perhaps let's spell out
> embedded_controller
>

Thanks for you review, I will rename the label to embedded_controller.
> [...]
> 
>> +&thermal_zones {
>> +	ec-back-cover {
>> +		polling-delay = <10000>;
>> +		thermal-sensors = <&ec 2>;
>> +
>> +		trips {
>> +			trip-point0 {
>> +				temperature = <90000>;
> This is *really* hot!
>

The 90°C trip value was suggested by thermal team(Manaf Meethalavalappu
Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>). We are open to using a
lower value if this is too high for the keyboard and back-cover sensors.
>> +				hysteresis = <5000>;
>> +				type = "hot";
>> +			};
>> +		};
>> +	};
>> +
>> +	ec-keyboard {
>> +		polling-delay = <10000>;
>> +		thermal-sensors = <&ec 1>;
>> +
>> +		trips {
>> +			trip-point0 {
>> +				temperature = <90000>;
> Likewise
> 
> Konrad

-- 
Best Regards,
Anvesh