Re: [PATCH v15 16/16] tools/testing/cxl: Add HDM decoder range checks

[Srirangan Madhavan]

On 10/26/26 7:41 PM, Alison Schofield wrote:
> Hi Srirangan,
>
> Thanks for adding these tests. The boundary and overflow cases provide
> valuable coverage for cxl_hdm_unpack_decoder().
>
> However, the fact that these tests don't require the mock CXL topology
> suggests that they belong in KUnit rather than cxl_test.
>
> BTW, but pointless once this moves to KUNIT, as written a failure in
> any one of these checks prevents the cxl_test module from loading,
> meaning all cxl unit tests would skip or fail.
>
> Please take a look at the recently posted CXL KUnit tests. I think
> this would fit nicely there.
> https://lore.kernel.org/all/cover.1791949910.git.alison.schofield@xxxxxxxxx/
>
> one bit inline below -

Thank you for the suggestion. I moved the decoder unpacking checks from 
cxl_test to a KUnit suite in v16. The uncommitted decoder case no longer 
checks the target type.

The test layout follows your proposed CXL KUnit infrastructure and has 
some duplication. Once your series lands, I'll rebase these tests onto it.

--
Regards,
Srirangan