RE: [PATCH v5 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge

[Hermes.Wu]

Hi Krzysztof
>
>-----Original Message-----
>From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> 
>Sent: Friday, October 30, 2026 5:56 PM
>To: Hermes Wu (吳佳宏) <Hermes.Wu@xxxxxxxxxx>
>Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>; Neil Armstrong <neil.armstrong@xxxxxxxxxx>; Robert Foss <rfoss@xxxxxxxxxx>; Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>; Jonas Karlman <jonas@xxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter <simona@xxxxxxxx>; Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>; Pet Weng (翁玉芬) <Pet.Weng@xxxxxxxxxx>; Kenneth Hung (洪家倫) <Kenneth.Hung@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>Subject: Re: [PATCH v5 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge
>
>On Thu, Oct 29, 2026 at 06:12:30PM +0800, Hermes Wu wrote:
>> Add device tree binding documentation for the ITE IT6162 MIPI DSI to 
>> HDMI 2.0 bridge chip. The IT6162 is an I2C-controlled bridge that 
>> supports the following configurations:
>> 
>>   - Single MIPI DSI input: up to 4K @ 30Hz
>>   - Dual MIPI DSI input (combined): up to 4K @ 60Hz
>> 
>> The chip also supports up to 8-channel audio output via 4 I2S data 
>> channels.
>> 
>> Assisted-by: Claude Opus 5.5
>
>Drop the tag now, rules changed.
>
Thanks, I will drop it in v6.

>Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
>
I ran checkpatch.pl, with and without --strict, on both patches. The
only remaining warning is "does MAINTAINERS need updating?" on this
patch. The MAINTAINERS entry that covers ite,it6162.yaml is added in
patch 2/2, so I will keep it there unless you prefer it in this patch.

>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thank you for the review.

>Best regards,
>Krzysztof
>

Regards,
Hermes