Re: [PATCH v2 18/18] perf test symbols: Add tests for symbol shrinking and session alloc wrappers

[Alireza Haghdoost]

On Tue, Oct 27, 2026 at 4:15 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> + if (!dso__can_shrink_symbols(dso) || dso__kernel(dso))
> + return TEST_OK;

This passes without testing anything when the DSO can't be shrunk, for
example a perf binary without .symtab. TEST_SKIP would make that
visible.

No test makes an allocation fail, so the shrink-and-retry path in the
session wrappers, where 12/18 combines with the 15-17/18 plumbing,
never runs. Other gaps:

- a reload after the file is gone (15/18)
- a lookup from another thread during a reload
- kallsyms alias groups (09/18)
- the merge sort with many ties
- after a reload, only one symbol's identity is checked, not the count
or the order

Thanks,
Alireza