Re: [PATCH v3 13/16] drm/msm/a8xx: Add all CP_PROTECT_PIPE to pwrup reglist

From: Rob Clark

Date: Fri Oct 30 2026 - 10:43:44 EST


On Fri, Oct 30, 2026 at 6:46 AM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 10/29/26 9:16 PM, Rob Clark wrote:
> > We're going to start using more of the CP_PROTECT_PIPE regs. Rather
> > than missing to restore one somewhere, just add them all to the pwrup
> > reglist.
> >
> > Signed-off-by: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
> > ---
>
> I was kinda hoping we would iterate over them in the code instead
> anyway for this one

I think it is possible to generate these.. so the looping would be in py ;-)

It might be worth re-purposing the 'value' field in
adreno_reglist_pipe to be # of consecutive regs? That would be a
straightforward way to compress the table on the generation side,
regardless of regs being an <array> or not.

For all the generated tables (esp. the snapshot tables) it would also
be nice to deduplicate identical tables.. either at generation time or
with the compiler.

> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

thx

BR,
-R