Re: [PATCH v3 2/3] regulator: Support regulators where the voltage selector spans two registers

[Mark Brown]

> Some devices uses 8-bit registers to store the voltage selector across
> two registers: one for the least significant bits and one for the most
> significant bits.

> +static int get_voltage_sel_reg(struct regulator_dev *rdev, unsigned int *sel)
> +{
> +	unsigned int val;
> +	__le16 buf;
> +	int ret;
> +
> +	if (rdev->desc->vsel_reg_oversize) {
> +		if (regmap_get_val_bytes(rdev->regmap) != 1)
> +			return -EINVAL;

Can't we validate this while registering the regulator rather than on
every read?

>  EXPORT_SYMBOL_GPL(regulator_get_voltage_sel_regmap);
>  
> +
>  /**

Random whitespace change.

-- 
Mark Brown <broonie@xxxxxxxxxx>