Re: [PATCH v4 2/2] i2c: Add Synopsys Advanced I2C (DWC_i2c) driver
From: Aniket Limaye
Date: Sat Oct 31 2026 - 05:56:26 EST
On 28/10/26 12:44, Uwe Kleine-König wrote:
Hello,
On Tue, Oct 27, 2026 at 05:00:36PM +0530, Aniket Limaye wrote:
+#include <linux/mod_devicetable.h>
[...]
+#include <linux/platform_device.h>
Please don't include <linux/mod_devicetable.h>.
<linux/platform_device.h> already gives you everything you'd expect from
<linux/mod_devicetable.h> without introducing a bunch of unneeded build
dependencies.
Best regards
Uwe
Noted, will fix this in next version
Thanks for the review!
Aniket