Re: [PATCH v2 5/8] arm64: dts: qcom: sm6350-lena: Enable Bluetooth

[erebion]

Hi,

On 10/15/26 13:06, Konrad Dybcio wrote:
> I don't like how these comments are spreading across the tree as
> everyone copy-pastes them.

It seems other DTs are just useful as working examples. :D

> On newer platforms, we settled on
> setting bias-disable everywhere and there don't seem to be any
> issues. Are these edits beneficial in any way?

the following errors in the log disappear with it included:

 Bluetooth: HCI UART driver ver 2.3
 Bluetooth: HCI UART protocol H4 registered
 Bluetooth: HCI UART protocol QCA registered
 Bluetooth: hci0: setting up wcn399x
-Bluetooth: hci0: Frame reassembly failed (-84)
 Bluetooth: hci0: QCA Product ID   :0x0000000a
 Bluetooth: hci0: QCA SOC Version  :0x40010320
 Bluetooth: hci0: QCA ROM Version  :0x00000302
 Bluetooth: hci0: QCA Downloading qca/crnv32u.bin
 Bluetooth: hci0: QCA setup on UART is completed
 Bluetooth: MGMT ver 1.23
 Bluetooth: hci0: setting up wcn399x
-Bluetooth: hci0: Frame reassembly failed (-84)
 Bluetooth: hci0: QCA Product ID   :0x0000000a
 Bluetooth: hci0: QCA SOC Version  :0x40010320
 Bluetooth: hci0: QCA ROM Version  :0x00000302
 Bluetooth: hci0: QCA Patch Version:0x00000de9
 Bluetooth: hci0: QCA controller version 0x03200302
 Bluetooth: hci0: QCA Downloading qca/crbtfw32.tlv
 Bluetooth: hci0: QCA Downloading qca/crnv32u.bin
 Bluetooth: hci0: QCA setup on UART is completed

Those appear if I remove &qup_uart1_cts / &qup_uart1_rts / &qup_uart1_rx 
/ &qup_uart1_tx from this patch.

But as those errors do not occur with this patch as-is, I'm leaving the 
patch as-is for now in my next version of the patch series.

> FWIW I think this claim of lower power here is just preventing
> leakage current from a floating pin..
>
> Konrad

--
erebion

XMPP: erebion@xxxxxxxxxx

My languages: German, English, Swedish, Norwegian, Danish
Yes, I'm a language nerd. Feel free to write to me in any of the 
aforementioned languages.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature