Re: [PATCH] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function

[Konrad Dybcio]

On 11/1/26 11:00 AM, Suraj Sonawane wrote:
> LPASS LPI gpio5 can mux EXT_MCLK1_C, but that function slot is left
> unnamed, so a device tree cannot select it. SC8280XP already names the
> same slot ext_mclk1_c.
> 
> Name the slot on SC7280 and assign it to gpio5. The third slot stays
> empty; on SC8280XP it is qua_mi2s_data.
> 
> This file also provides the SM8350 LPASS LPI driver, which uses the
> same pin table, so the function becomes available on SM8350 as well.
> 
> Tested on the Vicharak Axon Mini (QCS6490): selecting this mux slot
> drives the codec master clock, and ES8388 playback and headset capture
> work. Not tested on SM8350.
> 
> Signed-off-by: Suraj Sonawane <surajsonawane0215@xxxxxxxxx>
> ---
>  drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> index a61df10d4..278d5fac8 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> @@ -34,6 +34,7 @@ enum lpass_lpi_functions {
>  	LPI_MUX_swr_tx_data,
>  	LPI_MUX_wsa_swr_clk,
>  	LPI_MUX_wsa_swr_data,
> +	LPI_MUX_ext_mclk1_c,

This name happens to match the kodiak hw specification too

FWIW you need to update the dt-bindings to accomodate it

otherwise

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad