Re: [PATCH] powerpc/crash: update fdt on cpu hotplug remove

[Jinjie Ruan]

在 2026/11/3 16:53, Shivang Upadhyay 写道:
> Currently fdt for crash kernel is not updated on cpu hotplug remove,
> which can lead to the following XIVE warnings on the crash kernel
> bringup.
> 
> [    0.630795][    T1] xive: H_INT_GET_QUEUE_INFO cpu=16 prio=6 failed -55
> [    0.630912][    T1] xive: Error -55 getting queue info CPU 16 prio 6
> [    0.680899][    T1] xive: H_INT_GET_QUEUE_INFO cpu=17 prio=6 failed -55
> [    0.681000][    T1] xive: Error -55 getting queue info CPU 17 prio 6
> 
> Fixing this by updating crash fdt on cpu hotplug remove path also.
> 
> Reported-by: Anushree Mathur <anushree.mathur@xxxxxxxxxxxxx>
> Suggested-by: Sourabh Jain <sourabhjain@xxxxxxxxxxxxx>
> Signed-off-by: Shivang Upadhyay <shivangu@xxxxxxxxxxxxx>
> ---
>  arch/powerpc/kexec/crash.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
> index 775895f31037..0ef10e39ae49 100644
> --- a/arch/powerpc/kexec/crash.c
> +++ b/arch/powerpc/kexec/crash.c
> @@ -639,8 +639,6 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg)
>  
>  	switch (image->hp_action) {
>  	case KEXEC_CRASH_HP_REMOVE_CPU:
> -		return;
> -

LGTM
Reviewed-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

>  	case KEXEC_CRASH_HP_ADD_CPU:
>  		update_crash_fdt(image);
>  		break;

-- 
Best regards,
Jinjie