Re: [PATCH] xfs: add __printf attribute to xfs_buf_alert_ratelimited()
From: Carlos Maiolino
Date: Tue Nov 03 2026 - 05:09:41 EST
On Tue, 20 Oct 2026 21:56:28 +0200, Adrián García Casado wrote:
> xfs_printk_level() and _xfs_alert_tag() in fs/xfs/xfs_message.h are
> annotated with __printf(3, 4), but xfs_buf_alert_ratelimited() in the
> same header is missing the attribute.
>
> Because xfs_buf_alert_ratelimited() formats its variadic arguments via
> struct va_format and %pV, the compiler does not suggest the format
> attribute under -Wsuggest-attribute=format, and callers do not get
> compile-time format string checking.
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: add __printf attribute to xfs_buf_alert_ratelimited()
commit: 976d3cd5b0a307881a0772f2fb8d4557c2f4994b
Best regards,
--
Carlos Maiolino <cem@xxxxxxxxxx>