Re: [PATCH v3 1/3] iio: proximity: sx9310: keep the IRQ balanced across suspend and resume
From: Andy Shevchenko
Date: Tue Nov 03 2026 - 05:32:57 EST
On Sun, Nov 01, 2026 at 01:54:16AM +0000, Jonathan Cameron wrote:
> On Thu, 29 Oct 2026 03:34:37 +0530
> Arnav Kapoor <kapoorarnav43@xxxxxxxxx> wrote:
>
> > sx9310_suspend() disables the interrupt first and returns with it still
> > disabled if a register access fails. Resume isn't called after a failed
> > suspend, so the interrupt is never enabled again. sx9310_resume() also
> > returns without enabling it on error. Without an interrupt line,
> > client->irq is 0 and both callbacks act on IRQ 0, which the driver
> > doesn't own.
>
> irq 0 doesn't exist any more on any architectures I think..
> It did once, long ago. Today it means no interrupt.
...on the new architectures (?), on the old ones we have to live with it.
--
With Best Regards,
Andy Shevchenko