Re: [PATCH ath-next 1/3] wifi: ath10k: set the PMF peer flag on WCN3990

From: Loic Poulain

Date: Tue Nov 03 2026 - 08:55:22 EST


Hi Shunsuke,

On Tue, Nov 3, 2026 at 12:08 PM Nagashima, Shunsuke <shunsuke@xxxxxxxxxx> wrote:
>
> Hi Loic,
>
> On Tue, Nov 3, 2026 at 10:20 AM Loic Poulain wrote:
> > For change request I think the best for this is probably to follow
> > board like change:
> > https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html
> >
> > Please, keep me in CC.
>
> Thanks. I'll send it to the ath10k list in that format, with you in CC.
>
> One question first, about which file to change. In linux-firmware, the
> shared WCN3990/hw1.0/firmware-5.bin goes with wlanmdsp.mbn
> WLAN.HL.2.0-01387 (sdm845 boards such as db845c and SHIFT axolotl).
> qcm2290 and shikra have their own firmware-5.bin, picked through the
> firmware-name DT property.
>
> My comma four runs WLAN.HL.2.0.c10-00459, which comma ships itself. It
> is not in linux-firmware, and the comma four device tree is not
> upstream, so a per-board file would not help anyone else. But I have
> only tested the bit with c10-00459, not with 01387, and I don't have a
> db845c.
>
> Is that enough to change the shared file, or should someone test 01387
> first?

If Linux-firmware ships 01387, someone will need to confirm that the
MFP capability addition works with that specific firmware version. For
QCM2290, I can probably test it myself and provide a Tested-by tag if
you can describe the expected testing procedure.

> Also, the page says Kalle adds the files. Should I address the mail to
> Jeff now?

Yes, to Jeff.